RFE: assign custom security groups #508

[patlachance]

#508 Handling Security Groups and Security Group IDs for AWS

To attach custom security groups to your "nanocloud exec servers", proceed as follow:

From AWS console or using the aws-cli tool

• find your AWS SubNet ID
• find your AWS Security Group names or AWS Security Group IDs

Then, configure your Nanocloud environment using the values just found by changing config/env/development or creating a config/local.js file

• set the 'awsMachineSubnet' parameter
• set either awsSecurityGroups or awsSecurityGroupIds parameter

Sample config/local.js file:

module.exports = {
  nanocloud: {
    awsMachineSubnet: 'subnet-1a2b3c4d',
    awsSecurityGroupIds: ['sg-1a2b3c4d']
  }

You must choose Security Group(s) or Security Groups ID(s) that are define within the VPC containing the subnet referred to by the awsMachineSubnet parameter.

Configure only one of the two parameters. Setting both is useless and might result in provisioning error if they don't match.

Please note that using Security Group name(s) is only supported in EC2-Classic or in the default VPC, not in user-created VPCs. From AWS EC2 'runInstances' SDK function documentation
(http://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/EC2.html#runInstances-property)

• SecurityGroups — (Array)
  [EC2-Classic, default VPC] One or more security group names. For a nondefault VPC, you must use security group IDs instead.

Default: Amazon EC2 uses the default security group.

• SecurityGroupIds — (Array)
  One or more security group IDs. You can create a security group using CreateSecurityGroup.

Default: Amazon EC2 uses the default security group.

Notes:

• couldn't find existing tests for the AWS driver at all, so example to start from to test these new parameters but tested them on my config and it works.

[coveralls]

Coverage remained the same at 70.542% when pulling bc59199 on patlachance:feature-508-assign-custom-security-groups into eaf00b4 on Nanocloud:master.

[Gentux]

I can't fully test this feature, but I can say the code is clean