fix(release): publish correctly to github #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodinsamuel
force-pushed
the
fix/pkg-release
branch
from
330bb3a
to
4e7cd54
Compare
bodinsamuel
force-pushed
the
fix/pkg-release
branch
from
4e7cd54
to
bbc48ae
Compare
TBonnin
approved these changes
May 10, 2024
scripts/gitrelease.mjs
Outdated
| @@ -14,10 +14,24 @@ if (tagExists.stdout !== '') { | |||
| } | |||
|
|
|||
| const releaseMessage = `chore(release): ${nextVersion} [skip ci]`; | |||
|
|
|||
| echo`Checkout out branch`; | |||
| await $`git fetch`; | |||
There was a problem hiding this comment.
we can probably speed things up by only fetching the branch we are interested in
bodinsamuel
added a commit
that referenced
this pull request
May 13, 2024
## Describe your changes Follow up of #2141 Release worked but not the publish of the changelog - Fetch all commits by default - Improve grouping in changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Turns out we don't have access to the full repo by default, have to fetch and checkout the proper branch and setup an author. You can check the commit it created on this branch 4ab23d2