fix: batchDelete returns incorrect sync result #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
commented
Mar 26, 2024
| @@ -164,7 +164,7 @@ describe('Running sync', () => { | |||
| { id: '1', name: 'a' }, | |||
| { id: '2', name: 'b' } | |||
| ]; | |||
| const expectedResult = { added: 0, updated: 0, deleted: 0 }; | |||
| const expectedResult = { added: 0, updated: 0, deleted: 2 }; | |||
There was a problem hiding this comment.
I had the wrong test 🤦
bodinsamuel
approved these changes
Mar 26, 2024
TBonnin
commented
Mar 26, 2024
|
|
||
| if (softDelete) { | ||
| return { | ||
| success: true, | ||
| summary: { | ||
| deletedKeys: [...addedKeys, ...updatedKeys], |
There was a problem hiding this comment.
addedKeys would be empty, since it is checking if the ids is already in the db. UpdatedKeys is also empty if the record hash hasn't changed
TBonnin
force-pushed
the
tbonnin/NAN-641/batch-delete-incorrect-result
branch
from
612211f
to
065b75e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Sync can return incorrect deletion results.
Fixing by getting directly getting the modified rows when
soft_delete = trueIssue ticket number and link
https://linear.app/nango/issue/NAN-641/batchdelete-doesnt-return-the-correct-result
Checklist before requesting a review (skip if just adding/editing APIs & templates)