record id should not change between script executions #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the record internal id is modified every time a record is updated which is counter intuitive and makes debugging harder With this commit a record id is now a uuid v5 generated from the unique composite key (connection, model, external id)
khaliqgant
approved these changes
Mar 21, 2024
bodinsamuel
approved these changes
Mar 21, 2024
TBonnin
commented
Mar 21, 2024
| // to generate stable record ids across script executions | ||
| const stableId = (rawRecord: DataResponse): string => { | ||
| const namespace = uuid.v5(`${nango_connection_id}${model}`, uuid.NIL); | ||
| return uuid.v5(`${nango_connection_id}${model}${rawRecord.id}`, namespace); |
There was a problem hiding this comment.
having a namespace hierarchy is not mandatory, we could use a constant root namespace. Let me know what you think?
There was a problem hiding this comment.
could be just nango_connection_id yes, otherwise I'm fine with this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Currently the record internal id is modified every time a record is updated which is counter intuitive and makes debugging harder
With this commit a record id is now a uuid v5 generated from the unique composite key (connection, model, external id)