Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor track_deletes #1892

Merged
merged 13 commits into from Mar 25, 2024
Merged

Refactor track_deletes #1892

merged 13 commits into from Mar 25, 2024

Commits on Mar 25, 2024

  1. add test for run.service

    @TBonnin
    TBonnin committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    68acdc7 View commit details
    Browse the repository at this point in the history

  2. sync and syncJob ids are not optional

    @TBonnin
    TBonnin committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    cc9cd24 View commit details
    Browse the repository at this point in the history

  3. more tests for run.service

    @TBonnin
    TBonnin committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    605b503 View commit details
    Browse the repository at this point in the history

  4. refactor track_deletes: no need for snapshot table

    @TBonnin
    TBonnin committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    574bb59 View commit details
    Browse the repository at this point in the history

  5. clean mentions of _nango_sync_data_records_deletes table

    @TBonnin
    TBonnin committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    9bbe8e8 View commit details
    Browse the repository at this point in the history

  6. fix: lastSyncDate and trackDelete are not required by persist endpoints

    @TBonnin
    TBonnin committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    3ac0ec6 View commit details
    Browse the repository at this point in the history

  7. fix: only mark as deleted non-deleted records

    @TBonnin
    TBonnin committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    39c888e View commit details
    Browse the repository at this point in the history

  8. fix: mark as deleted only records from current sync

    @TBonnin
    TBonnin committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    8a3d5b8 View commit details
    Browse the repository at this point in the history

  9. data service: use constants for table and unique key

    @TBonnin
    TBonnin committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    12238c5 View commit details
    Browse the repository at this point in the history

  10. test tweaks + fix bug when readding deleted records

    @TBonnin
    TBonnin committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    0e7282d View commit details
    Browse the repository at this point in the history

  11. markNonCurrentGenerationRecordsAsDeleted only needs to return ids

    @TBonnin
    TBonnin committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    8d0cbd3 View commit details
    Browse the repository at this point in the history

  12. fix: reset createdAt to now for record previously deleted

    @TBonnin
    TBonnin committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    57ced19 View commit details
    Browse the repository at this point in the history

  13. fix: discard records with deleted_at in getAddedKeys knownKeys

    @TBonnin
    TBonnin committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    f2e2ae7 View commit details
    Browse the repository at this point in the history