fix(shared): proper ts rootDir #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaliqgant
approved these changes
Mar 20, 2024
TBonnin
approved these changes
Mar 20, 2024
|
Looks good on staging ✅ |
bodinsamuel
added a commit
that referenced
this pull request
Mar 21, 2024
## Describe your changes Follow up of #1887 Obviously it wasn't going to be easy. For some reason changing the path also lead to npm not publishing the dist folder [0.39.5](https://www.npmjs.com/package/@nangohq/shared/v/0.39.5?activeTab=code) vs [0.39.6](https://www.npmjs.com/package/@nangohq/shared/v/0.39.6?activeTab=code) - Explicitly list published files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes NAN-617
rootDir was not pointing to lib
It currently output everything to dist/lib which is inconvenient but also makes the paths unreliable since it changes from ts to js
Fix package.json loading (and cache it)
This package.json is loaded on every call to
/meta.And it was spamming errors in tests