fix: nango deps version and publish.sh #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodinsamuel
reviewed
Mar 7, 2024
scripts/publish.sh
Outdated
| @@ -30,23 +30,23 @@ npm install | |||
|
|
|||
| # Node client | |||
| bump_and_npm_publish "@nangohq/node" "$VERSION" | |||
| pushd "./packages/shared"; npm install "@nangohq/node@$VERSION"; popd; | |||
| pushd "$GIT_ROOT_DIR/packages/shared"; npm install -E @nangohq/node@^$VERSION; popd; | |||
There was a problem hiding this comment.
are you sure? you have -E and the caret :D
we are requesting exact install and pass the caret one
There was a problem hiding this comment.
oups. forgot to remove -E
TBonnin
force-pushed
the
tbonnin/fix-packages-version-0.39.0
branch
from
7160b97
to
bc65c43
Compare
khaliqgant
approved these changes
Mar 7, 2024
bodinsamuel
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes