New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable server rate limit #1772
Enable server rate limit #1772
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we give this more time? For some customers syncs run just once a week so are we really be sure that this won't affect anyone? I would suggest waiting or at least announce it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go 👍🏻
Should we document that somewhere? @bastienbeurier
Sure. we can wait. @bastienbeurier what do you think. |
Thanks for pointing out @bodinsamuel and for creating a ticket @TBonnin. I'll take care of it since I'm deep in the docs these days. |
@khaliqgant after how long would you feel confident to merge/release this PR? |
I would say a week so we can get a picture, so I guess that would be Thursday? |
4d1f3d3
to
093d097
Compare
093d097
to
7b4cab2
Compare
Describe your changes
Enabling rate-limiting (was only logging so far).
Since I pushed the memoization of getConnection yesterday, no rate limiting has been logged so it should not impact anybody.
followup of #1708