Add uninstall option to modules #3449
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partydragen
previously approved these changes
Mar 9, 2024
| !str_contains($directory, 'custom') || | ||
| !str_contains($directory, 'modules') || | ||
| !str_contains($directory, 'uploads') | ||
| ) { |
There was a problem hiding this comment.
This does not look right. Won’t this always return false unless the string contains custom, modules AND uploads?
There was a problem hiding this comment.
Looks fine to me. It aborts if:
- The path contains "Core" (to prevent deleting modules/Core)
- OR the path does not contain "custom"
- OR the path does not contain "modules"
- OR the path does not contain "uploads"
A resolved absolute path check would be better. Although this is not a security feature so it doesn't matter if it can be bypassed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.