Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create CacheCollector to display Cache stats in the debug bar #3396

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Create CacheCollector to display Cache stats in the debug bar #3396

wants to merge 1 commit into from

Conversation

tadhgboyle
Copy link
Member

image

@tadhgboyle tadhgboyle added this to the 2.1.x milestone Jun 16, 2023
@Derkades Derkades modified the milestones: 2.1.1, 2.1.2 Jun 19, 2023
samerton
samerton requested changes Aug 21, 2023
View reviewed changes
core/classes/Core/Cache.php
$is_cached = false;
}

CacheCollector::getInstance()->recordCheck($key, $is_cached);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we be sure that, if we call this method, we won't see any errors in production websites (i.e. not using developer dependencies) because CacheCollector imports DebugBar

@samerton samerton modified the milestones: 2.1.2, 2.2.0 Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samerton samerton samerton requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tadhgboyle @samerton @Derkades