Revamp avatar system, remove MC avatars from core #3313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadhgboyle
force-pushed
the
feat/avatar-revamp
branch
2 times, most recently
from
9b88f5e
to
c62eb56
Compare
tadhgboyle
force-pushed
the
feat/avatar-revamp
branch
from
e1a4285
to
eaa1312
Compare
tadhgboyle
requested review from
partydragen and
a team
and removed request for
partydragen
partydragen
reviewed
Jun 10, 2023
| <table class="table table-borderless table-striped"> | ||
| <thead> | ||
| <tr> | ||
| <th>Name</th> |
| MinecraftAvatarSource::registerSource(new VisageMinecraftAvatarSource()); | ||
| } | ||
|
|
||
| // EventHandler::registerListener(UserIntegrationUnlinkedEvent::class, ResetAvatarCacheHook::class); |
There was a problem hiding this comment.
Those should be uncommented?
partydragen
requested changes
Jun 27, 2023
| public function get(User $user): ?string { | ||
| $base_url = ($this->_full_url ? rtrim(URL::getSelfURL(), '/') : '') . ((defined('CONFIG_PATH')) ? CONFIG_PATH . '/' : '/') . 'uploads/avatars'; | ||
|
|
||
| if (Settings::get('custom_user_avatars') && $user->data()->has_avatar) { |
There was a problem hiding this comment.
Allow custom user avatars? setting on custom avatar source does not save on enabled state
| } | ||
|
|
||
| foreach ($exts as $ext) { | ||
| if (file_exists(ROOT_PATH . "/uploads/avatars/{$user->data()->id}.{$ext}")) { |
There was a problem hiding this comment.
Need to be a way to remove or unselect default custom avatar
People most likey want Custom avatar to be priority one, and minecraft next but if they have uploaded a custom default image then they are not able to fallback to minecraft avatar
partydragen
requested changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.