Add user sessions page #3278
Open
Add user sessions page #3278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tadhg Boyle <tadhgsmboyle@gmail.com>
Co-authored-by: Tadhg Boyle <tadhgsmboyle@gmail.com>
Co-authored-by: Tadhg Boyle <tadhgsmboyle@gmail.com>
Co-authored-by: Tadhg Boyle <tadhgsmboyle@gmail.com>
partydragen
reviewed
Mar 20, 2023
| $user_sessions_list = []; | ||
|
|
||
| // TODO: Should we display all sessions, or just active ones? Over time, the list could get very long if we display all sessions. | ||
| // Not really any reason to show inactive ones, since they can't action on them. |
There was a problem hiding this comment.
Showing inactive ones can help us find if the account has been compromised or not, Hiding sessions could miss unwanted logins
partydragen
reviewed
Mar 20, 2023
| $sessions = $user->getActiveSessions(); | ||
| $sessions_list = []; | ||
| // TODO: Should we display all sessions, or just active ones? Over time, the list could get very long if we display all sessions. | ||
| // Not really any reason to show inactive ones, since they can't action on them. |
There was a problem hiding this comment.
Showing inactive ones can help us find if the account has been compromised or not, Hiding sessions could miss unwanted logins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #3104
