Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ROOT_PATH constant to a class #3246

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Move ROOT_PATH constant to a class #3246

wants to merge 7 commits into from

Conversation

Derkades
Copy link
Member

@Derkades Derkades commented Feb 2, 2023

Why?

  • It no longer needs to be set manually (like in CLI installer, seeder, etc), reducing the possibility of errors when files are moved
  • Tools like phpstan do not like global constants

@Derkades Derkades added this to the 2.2.0 milestone Feb 2, 2023
supercrafter100
supercrafter100 previously requested changes Feb 2, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
core/classes/Misc/Constants.php Show resolved Hide resolved
core/migrations/phinx.php Outdated Show resolved Hide resolved
dev/scripts/seeder/db_seeder.php Outdated Show resolved Hide resolved
install.php Show resolved Hide resolved
@tadhgboyle tadhgboyle changed the title Move ROOT_PATH constant to a class Move ROOT_PATH constant to a class Feb 9, 2023
@tadhgboyle tadhgboyle modified the milestones: 2.2.0, 2.1.0 Feb 9, 2023
@tadhgboyle
Copy link
Member

I think we should keep the ROOT_PATH constant for 2.1.0, and then remove it in 2.2.0 - just to spread out the massive breaking changes a bit for module devs

partydragen
partydragen previously requested changes Feb 9, 2023
View reviewed changes
index.php Show resolved Hide resolved
@Derkades Derkades dismissed stale reviews from partydragen and supercrafter100 April 25, 2023 07:52

resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadhgboyle tadhgboyle tadhgboyle left review comments

@partydragen partydragen partydragen left review comments

@supercrafter100 supercrafter100 supercrafter100 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Derkades @tadhgboyle @partydragen @supercrafter100