Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding code, example and unit test for 1D / 2D planar arrays beamforming weight computation. #371

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mauro-belgiovine
Copy link

Description

I have developed this code to allow 2D and 3D analog beamforming using 1D or 2D planar array in Sionna. I have added an example notebook that demonstrate the effect of both types of beamforming and show how to use the code in simulation.

  • Fixes a bug?

No.

  • Adds a new feature?

Based on previous discussions in this issue, I have developed this code to add a precoding_weights function to an antenna array object (either 1D or 2D array). This function allows to specify azimuth and elevation angles and obtain the relative precoding weights for a given array geometry. Such weights can be then plugged into the scene.coverage_map function in the relative argument to apply the desired steering vector when computing signal propagation maps.

  • Introduces API changes?

It doesn't introduce API changes, however there's a conflict with current Sionna release with respect to the trainable_* parameters in AntennaArray.__init__, which appear to be deprecated in latest Sionna release. I have developed this code for a previous version of the framework and it still runs fine after synchronizing with the main repo, however I am happy to adapt the initialization mechanism for the trainable variables if you could explain how this is handled in the latest release.

I have added an example notebook and included the relative unit test, however it seems like the general unit tests routine (i.e. make test) fails in the last Sionna release due to other reasons? The specific test function I have added passes with no errors, but also open to edit it accordingly.

  • Other contributions

n/a

Checklist

  • Detailed description
  • Added references to issues and discussions
  • Added / modified documentation as needed
  • Added / modified unit tests as needed
  • Passes all tests
  • Lint the code
  • Performed a self review
  • Ensure you Signed-off the commits. Required to accept contributions!
  • Co-authored with someone? Add Co-authored-by: user@domain and ensure they signed off their commits too.

…utation based on azimuth/elevation angle.

Signed-off-by: Mauro Belgiovine <mbelgiovine89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant