Fix model replication issue when using PointNet2SetAbstraction with nn.DataParallel #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acivgin1
force-pushed
the
master
branch
4 times, most recently
from
be39fd7
to
4c4e009
Compare
Signed-off-by: acivgin1 <amar.civgin@gmail.com>
JayantGoel001
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
nn.DataParallel, modules registered insidePointNet2SetAbstraction'sself.sub_modulesare replicated to different devices, and the objects (tuple ofgrouper,pointnet,num_samples) inself.layersremain on the first device. This causes issues when working withnn.DataParallel.This fix removes the helper attribute of
self.layersand directly uses the submodules registered withnn.ModuleListin the forward pass.