Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pointcloudfunc.py #252

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update pointcloudfunc.py #252

wants to merge 1 commit into from

Conversation

nirmal-suthar
Copy link

@nirmal-suthar nirmal-suthar commented May 7, 2020 •
edited

Fix bug in NormalizePointCloud ( doesn't accept kaolin.rep.PointCloud )

Caenorst
Caenorst previously approved these changes May 31, 2020
View reviewed changes
Copy link
Collaborator

@Caenorst Caenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks ! :)

@Caenorst
Copy link
Collaborator

Caenorst commented Jun 1, 2020

Can you rebase and force push again so the PR pass the CI ? the current problem is fixed by #262

@nirmal-suthar
Update pointcloudfunc.py
39bfb36 
Signed-off-by: nirmal <nirmalps@iitk.ac.in>
@nirmal-suthar
Copy link
Author

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Caenorst Caenorst Caenorst left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nirmal-suthar @Caenorst