Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug where user can't select some resolutions in game #55

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sortifal
Copy link

Fixed a bug where resolutions could'nt be set properly on high resolutions. Set back omni material dependecy version back to 11 to be build compliant.

@xoxor4d
Copy link
Contributor

xoxor4d commented Jan 28, 2024

fyi (nv) - this is already integrated into dxvk: doitsujin/dxvk#3214

@nvzkupu
Copy link
Collaborator

nvzkupu commented Jan 28, 2024

There was an issue with version 12 of rtx-remix-omni_core_materials not being publicly available. We have since resolved the temporary issue and this change should no longer be required.

@sortifal Please test with version 12 of rtx-remix-omni_core_materials again and let us know if the problem selecting some resolutions remains.

@sortifal
Copy link
Author

There was an issue with version 12 of rtx-remix-omni_core_materials not being publicly available. We have since resolved the temporary issue and this change should no longer be required.

@sortifal Please test with version 12 of rtx-remix-omni_core_materials again and let us know if the problem selecting some resolutions remains.

The v12 of 'rtx-remix-omni_core_materials' now compile properly but the resolutions problem is still here. Do you want me to make a new PR with v12 ?

@nvzkupu
Copy link
Collaborator

nvzkupu commented Jan 29, 2024

@sortifal No, you can keep this PR in place, just modify the configs to pull v12 of rtx-remix-omni_core_materials.

Thank you for confirming and verifying that the resolution issue is still present, even with v12.

@sortifal
Copy link
Author

@sortifal No, you can keep this PR in place, just modify the configs to pull v12 of rtx-remix-omni_core_materials.

Thank you for confirming and verifying that the resolution issue is still present, even with v12.

I know pushed a fix with v12 of rtx-remix-omni_core_materials. I confirm that the problem was still there with v12 (tested on call of duty 2) and is fixed with the things I changed.

@AlexDunn
Copy link
Collaborator

@sortifal thank you for putting this PR together.

I noticed that this fix is a squashed version of the upstream fix from DXVK (commits below). Would it be possible to cherrypick those commits directly? This will greatly help us when it comes time to merge upstream DXVK into Remix.

Also please add yourself as a contributer to the credits (see ImGuiAbout::Credits::Credits()) in a separate commit.

doitsujin/dxvk@1568c26
doitsujin/dxvk@0cd4165
doitsujin/dxvk@4b8e8be

@sortifal
Copy link
Author

@sortifal thank you for putting this PR together.

I noticed that this fix is a squashed version of the upstream fix from DXVK (commits below). Would it be possible to cherrypick those commits directly? This will greatly help us when it comes time to merge upstream DXVK into Remix.

Also please add yourself as a contributer to the credits (see ImGuiAbout::Credits::Credits()) in a separate commit.

doitsujin/dxvk@1568c26 doitsujin/dxvk@0cd4165 doitsujin/dxvk@4b8e8be

Hello, I tried to compile by cherry-picking thoses 3 commits but he moved all operators out of dxvk namespace that conclude to a build error for previous definitions of thoses operators. Then only the inline bool operator == (const D3DDISPLAYMODEEX& a, const D3DDISPLAYMODEEX& b) needs to be out of the said namespace. (I also didn't find how to put me as a contributor)

@NV-LL
Copy link

NV-LL commented May 8, 2024

REMIX-3065 for tracking

@sortifal
Copy link
Author

sortifal commented May 9, 2024

I know it's been a while but I added myself as contributor as you said so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants