Make changes needed to have all host allocations go through a single plugable API #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plugable API Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
revans2
force-pushed
the
all_through_host_alloc
branch
from
d871674
to
a6c6d95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rapidsai/cudf#15026 makes it so that we can have all host memory allocations go through a plugable API. This fixes any build incompatibility with that change so that spark-rapids-jni can continue to work. It also cleans up a few small things, like making the logging for RMM deallocations to do the right thing for CPU vs GPU memory, and updates the injection APIs to take an enum instead of the ordinal for the enum. The other two are minor, but I thought made the code base cleaner and less error prone.