This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Initial port to new monorepo build system. #704
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
suggested changes
May 30, 2023
alliepiper
commented
May 30, 2023
alliepiper
commented
May 31, 2023
alliepiper
commented
May 31, 2023
|
In Now that we will be synchronizing versions across components, we aren't going to try and support mix&match different versions of components. |
alliepiper
force-pushed
the
monorepo_submodules
branch
from
bfe591e
to
1fdce39
Compare
gevtushenko
reviewed
Jun 22, 2023
Comment on lines
+140
to
+142
| if (CUB_ENABLE_RDC_TESTS OR CUB_FORCE_RDC) | ||
| set(use_rdc_for_catch2_utils ON) | ||
| endif() |
There was a problem hiding this comment.
Looks like else branch:
Suggested change
| if (CUB_ENABLE_RDC_TESTS OR CUB_FORCE_RDC) | |
| set(use_rdc_for_catch2_utils ON) | |
| endif() | |
| if (CUB_ENABLE_RDC_TESTS OR CUB_FORCE_RDC) | |
| set(use_rdc_for_catch2_utils ON) | |
| endif() |
This allows the install rules to be generated for all projects even when the dev builds are disabled.
These are now handled at the CCCL level, using newer and more robust techniques.
alliepiper
force-pushed
the
monorepo_submodules
branch
from
ab1c756
to
b729edb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.