Update customAllReduceKernels.cu - line 120's typo was edited #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At line 120, we have the matrix that has 2 dimensions. But at line 121, it mentions about dimension 0 and "dimension 2". I think it should be changed into "dimension 1". And this typo maybe occurred by block_barrier function, at line 148.
|
Hi @sjbae1999 , thanks a lot for your fix! We've integrated your fix into the internal codebase, which will be included in the next update to the GitHub main branch, Thanks again for the support and carefulness. |
kaiyux
approved these changes
May 20, 2024
|
Directly merging this PR since this is a one-line fix. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At line 120, we have the matrix that has 2 dimensions. But at line 121, it mentions about dimension 0 and "dimension 2". I think it should be changed into "dimension 1". And this typo maybe occurred by block_barrier function, at line 148.