Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note on build Llama v3 #1522

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add note on build Llama v3 #1522

wants to merge 1 commit into from

Conversation

sammcj
Copy link

@sammcj sammcj commented Apr 29, 2024

Update readme for building Llama v3 with it's increase vocab size.

@byshiue
Copy link
Collaborator

byshiue commented May 15, 2024

Thank you for the PR. Do you encounter any issue by using the convert_checkpoint.py and trtllm-build to build the engine? The vocab_size should be parsed by the converter and pass into engine automatically. We shouldn't need to set it manually.

@byshiue byshiue self-assigned this May 15, 2024
@byshiue byshiue added triaged Issue has been triaged by maintainers neeed more info labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@byshiue byshiue

Labels
neeed more info triaged Issue has been triaged by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sammcj @byshiue