Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct cudaSetDevice error when GPUs per node are fewer than their ranks in inter-node inference #1495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct cudaSetDevice error when GPUs per node are fewer than their ranks in inter-node inference #1495

wants to merge 1 commit into from

Conversation

littlefatfat
Copy link

@MartinMarciniszyn
Copy link
Collaborator

I am not in favor of having function parameter defaults that change depending on the environment. These should be compile time constants. I suggest changing run.py instead so that it passes the correct number of devices per node into the bindings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Funatiq Funatiq Awaiting requested review from Funatiq

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@littlefatfat @MartinMarciniszyn