Kazakh Configs Introduction #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
monica-sekoyan
commented
Apr 9, 2024
•
monica-sekoyan
commented
- Added Kazakh language 4 sources (MCV, SLR140, SLR102, KSC2)
- Merged with the branch "armenian" to get new processors and processors updates
- Added tests
erastorgueva-nv
requested changes
May 9, 2024
There was a problem hiding this comment.
Thank you for this PR! Please see comments.
Some additional things:
- Please add docs about supported languages, and preferably also the "API" as well
- see how it's done in eg the Portuguese PR - you will need to update some YAML and in some cases some RST files)
- you can view your build of the docs following instructions here
- there are some empty init files - I am not sure that we need them. If we do need them, they should contain the copyright header still
- Please reserve the merge conflict
- Please update the description of the PR (it says 2 language source but now there are 4)
monica-sekoyan
force-pushed
the
kazakh
branch
2 times, most recently
from
6582e01
to
211dc63
Compare
|
Implemented all the requested changed |
erastorgueva-nv
requested changes
May 14, 2024
monica-sekoyan
force-pushed
the
kazakh
branch
2 times, most recently
from
ac630c1
to
8154e37
Compare
Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com>
Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com>
Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com>
Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com>
Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com>
Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com>
Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com>
Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com>
Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com>
Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com>
Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com>
Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com>
Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com>
Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com>
Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com>
Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com>
Signed-off-by: monica-sekoyan <msekoyan@nvidia.com>
monica-sekoyan
force-pushed
the
kazakh
branch
2 times, most recently
from
8154e37
to
3bec314
Compare
Signed-off-by: monica-sekoyan <msekoyan@nvidia.com>
erastorgueva-nv
approved these changes
May 20, 2024
lilithgrigoryan
pushed a commit
to lilithgrigoryan/NeMo-speech-data-processor
that referenced
this pull request
May 21, 2024
* hook modification Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com> * adapt to the new changes Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com> * formatting Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com> * fix url composition Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com> * expand configs Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com> * add processing for kk Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com> * add tests for kazakh 2 sources Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com> * hook modification Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com> * adapt to the new changes Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com> * remove extra blank lines Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com> * correct copyright date Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com> * requested fixes Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com> * change counting instances Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com> * add documentation for kazakh configs Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com> * add kazakh to configs Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com> * minor fixes Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com> * add helper function Signed-off-by: monica-sekoyan <msekoyan@nvidia.com> * correct doc titles Signed-off-by: monica-sekoyan <msekoyan@nvidia.com> --------- Signed-off-by: Monica-Sekoyan <msekoyan@nvidia.com> Signed-off-by: monica-sekoyan <msekoyan@nvidia.com> Co-authored-by: Monica Sekoyan <msekoyan@Monicas-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.