Fix implicit computation of max_steps when gbs < rollout size
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also ensures this code is compatible with the change in
NVIDIA/NeMo#8744
which requires using a NeMo sampler to compute `max_steps` correctly
(it does not work with a basic PyTorch sampler).
Signed-off-by: Olivier Delalleau <507137+odelalleau@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also ensures this code is compatible with the change in
NVIDIA/NeMo#8744
which requires using a NeMo sampler to compute
max_stepscorrectly (it does not work with a basic PyTorch sampler -- though I will update that NeMo PR to make it work with a warning as this made be realize it could be breaking some user code otherwise).Tested locally on my workstation.