Geshen/async mcts #101
Draft
Geshen/async mcts #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gerald Shen <geshen@nvidia.com> fix Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Signed-off-by: Gerald Shen <geshen@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Yi Dong <yidong@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Gerald Shen <geshen@nvidia.com>
…to geshen/async_mcts
yidong72
reviewed
Feb 9, 2024
| return_value_memory.append((list(spg.value_memory), spg.data_id, backup_root_states[i])) | ||
| del parallel_searches[i] | ||
| del backup_root_states[i] | ||
| if is_terminal: |
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
yidong72
reviewed
Feb 9, 2024
| cfg.model, | ||
| trainer, | ||
| strict=True, | ||
| load_base_model_only=True, |
There was a problem hiding this comment.
will it cause a problem that the second time we load the improved hybrid network, it won't load the value head weights?
There was a problem hiding this comment.
the second time we load the value head, PTL will overwrite this checkpoint that we loaded, so it should be pretty safe
There was a problem hiding this comment.
okay. so you are loading from ckpt not nemo files
There was a problem hiding this comment.
yeah, so when we have no checkpoint it loads from the .nemo file, when there is a checkpoint it loads this .nemo file but PTL will overwrite it
yidong72
reviewed
Feb 9, 2024
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
gshennvm
force-pushed
the
geshen/async_mcts
branch
from
011e5f3
to
4ac5c9b
Compare
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT tracking only