Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zcharpy/bug 4472305 #100

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Zcharpy/bug 4472305 #100

wants to merge 21 commits into from

Conversation

Zenodia
Copy link

@Zenodia Zenodia commented Feb 5, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.
Adding steerable_attributes inside of NeMo-Aligner/examples/nlp/gpt/conf/gpt_sft.yaml files , in order to ensure whenever SteerLM training is finished, the .nemo file will also save these steerable_attributes into the model_config.yaml file

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.
    packaging steerable_attributes into .nemo tar file and make sure these attributes exists in the model_config.yaml after untar .nemo

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

gshennvm and others added 17 commits January 23, 2024 10:13
Signed-off-by: Gerald Shen <geshen@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Zenodia Charpy <zcharpy@nvidia.com>
Signed-off-by: Gerald Shen <geshen@nvidia.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants