Make DALI tests compatible with Python 3.12 #5452
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI MESSAGE: [14688850]: BUILD STARTED |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
JanuszL
force-pushed
the
make_test_python3.12_compat
branch
from
d171b28
to
087d99c
Compare
|
CI MESSAGE: [14689665]: BUILD STARTED |
JanuszL
force-pushed
the
make_test_python3.12_compat
branch
from
087d99c
to
435bb70
Compare
|
CI MESSAGE: [14689899]: BUILD STARTED |
- adds additional replacements for functions used by nose and removed in python 3.12 - remove numpy version pinning as the <1.26 is not compatible with python 3.12 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL
force-pushed
the
make_test_python3.12_compat
branch
from
435bb70
to
570cdb5
Compare
|
CI MESSAGE: [14691274]: BUILD STARTED |
|
CI MESSAGE: [14691274]: BUILD FAILED |
mzient
reviewed
May 6, 2024
Acknowledgements.txt
Outdated
|
|
||
|
|
||
| BEOPEN.COM LICENSE AGREEMENT FOR PYTHON 2.0 |
There was a problem hiding this comment.
Do we need to copy the old licenses, too?
There was a problem hiding this comment.
Probably not, removed.
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
stiepan
reviewed
May 6, 2024
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and removed in python 3.12
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
and removed in python 3.12
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-3958