Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DALI video plugin #5328

Merged
merged 39 commits into from May 21, 2024
Merged

Add DALI video plugin #5328

merged 39 commits into from May 21, 2024

Conversation

jantonguirao
Copy link
Contributor

@jantonguirao jantonguirao commented Feb 19, 2024 •
edited

Category:

New feature

Description:

Starts the skeleton of an upcoming DALI video plugin, as a source distribution that depends of PyNvVideoCodec for usage of VideoCodecSDK and utilities.

Additional information:

Affected modules and functionalities:

  • New plugin

Key points relevant for the review:

Approach to source distribution plugins

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: DALI-3866

@jantonguirao jantonguirao force-pushed the dali_plugin_video branch 2 times, most recently from d1657fa to 5ff7d73 Compare March 4, 2024 15:14
JanuszL
JanuszL reviewed Mar 12, 2024
View reviewed changes
docker/build_plugins.sh Outdated

export NVIDIA_DALI_BUILD_FLAVOR=${NVIDIA_DALI_BUILD_FLAVOR:-}
export NVIDIA_DALI_PLUGINS_INSTALL_DIR=${NVIDIA_DALI_PLUGINS_INSTALL_DIR:-install_plugins}
export GIT_SHA=$(git rev-parse HEAD)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make it externally passable as well. In CI we merge automation files to the repo so the shape of the build tree is a bit different than what is built.

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [13771761]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [13771906]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [13771947]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [13771906]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [13771947]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [13773214]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [13773214]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [13800514]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [13800602]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [13800514]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [13800602]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [13806692]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [13806692]: BUILD FAILED

@awolant awolant self-assigned this Apr 18, 2024
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14600227]: BUILD STARTED

@jantonguirao
Lint fix
472660a 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
copy all sdist tar.gz artifacts to runner docker
4f481d9 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Add pip dependencies to video_plugin test
cd8375b 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Fix ffmpeg dependency
a3ed3b0 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Use PyNvVideoCodec 1.0.2
c9194c9 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Undo unnecessary deps
249f13a 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Document plugin, rename to plugin.video.decoder
ed8cef4 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Remove prints
018b747 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Remove Python 3.13 from setup.py
9892cf6 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Preload libcuda stub
da2e777 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao jantonguirao marked this pull request as ready for review May 10, 2024 08:42
@jantonguirao jantonguirao changed the title Dali plugin video Add DALI video plugin May 10, 2024
@jantonguirao
Undo doc change from this PR
4aa9a90 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@JanuszL
Copy link
Contributor

JanuszL commented May 10, 2024

Can you also adjust cmake/lint.cmake and .github/workflows/lint.yml to scan video plugin?

awolant
awolant approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@awolant awolant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jantonguirao
Add linting
502f11b 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Add version check
62e58ed 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15162115]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15162115]: BUILD FAILED

@jantonguirao
Code review fixes
658a3b2 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15168736]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15168736]: BUILD PASSED

@jantonguirao jantonguirao merged commit 2098b93 into NVIDIA:main May 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanuszL JanuszL JanuszL left review comments

@mzient mzient mzient approved these changes

@awolant awolant awolant approved these changes

Assignees

@mzient mzient

@awolant awolant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jantonguirao @dali-automaton @JanuszL @mzient @awolant