Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fp16 in arithmetic and mathematical ops #4674

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

klecki
Copy link
Contributor

@klecki klecki commented Feb 22, 2023

Category: New feature

Description:

Add support for fp16 in arithmetic and mathematical ops

Additional information:

Affected modules and functionalities:

Arithm ops

Key points relevant for the review:

Any spots where we need to also adjust the config?

Tests:

  • Existing tests apply
    I added np.float16 to the tested types, the coverage is already pretty extensive.
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
@klecki
Copy link
Contributor Author

klecki commented Feb 22, 2023

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7390513]: BUILD STARTED

@klecki klecki marked this pull request as draft February 22, 2023 16:56
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8224542]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8224542]: BUILD FAILED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants