Add MPEG-4 Part2 decoding support #4361
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
JanuszL
reviewed
Oct 17, 2022
| class FramesDecoderGpuMpeg4Test : public FramesDecoderGpuTest { | ||
| void AssertFrame(uint8_t *frame, int index, TestVideo& ground_truth) override { | ||
| MemCopy(FrameDataCpu(), frame, ground_truth.FrameSize()); | ||
| SaveFrame(FrameDataCpu(), index, 0, 0, "/home/awolant/Downloads/frames/", ground_truth.Width(), ground_truth.Height()); |
|
CI MESSAGE: [6216597]: BUILD STARTED |
|
CI MESSAGE: [6216597]: BUILD FAILED |
Signed-off-by: Albert Wolant <awolant@nvidia.com>
|
CI MESSAGE: [6225403]: BUILD STARTED |
|
CI MESSAGE: [6225403]: BUILD FAILED |
|
CI MESSAGE: [6226244]: BUILD STARTED |
|
CI MESSAGE: [6226244]: BUILD FAILED |
|
I think you need to update conda/third_party/dali_ffmpeg/recipe/build.sh and https://github.com/NVIDIA/DALI/blame/main/docs/compilation.rst#L205 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds MPEG-4 Part2 decoding support for
FramesDecoderandFramesDecoderGpufor all usage patterns (regular, in-memory, no index).Category:
Description:
Based on #4327 by @JanuszL
Requires NVIDIA/DALI_deps#61 deps PR and NVIDIA/DALI_extra#109 DALI_extra PR.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A