Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tensor as batch in parallel external source #4207

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

stiepan
Copy link
Member

@stiepan stiepan commented Aug 30, 2022

Category:

New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)

Description:

  • Support specyfing batch as a single numpy array which leading extent is treated as a samples extent of a batch.
  • Support returning numpy scalars from a callback

All those cases have already been supported by non-parallel external source.

Additional information:

Affected modules and functionalities:

Parallel external source, external source, tensfor flow plugin(?)

Key points relevant for the review:

  • Does it enable something we would not like to enable?

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: DALI-2979

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
@stiepan
Copy link
Member Author

stiepan commented Aug 31, 2022

Keeping it as a draft to check first how it affects tf plugin.

@stiepan stiepan marked this pull request as draft August 31, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant