Reinitialize properties when deserializing #4097
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guard against a check using the Python graph that is not constructed during deserialization. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
When deserializing, the frontend values are not initialized. Initialize them based on the backend values. Needed to fix another part of feed_input to deserialized pipelines. An alternative would be to expose those properties directly from backend instead of copying them over. TODO: Remaining properties. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
klecki
force-pushed
the
backend-properties
branch
from
8ac6939
to
0d502a4
Compare
|
This is a part of one of two possible solutions - changing to draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category: Bug fix, Refactoring
Description:
First commit from #4096
When deserializing, the frontend values
are not initialized. Initialize them
based on the backend values.
Needed to fix another part of feed_input
to deserialized pipelines.
An alternative would be to expose
those properties directly from backend
instead of copying them over.
TODO: Remaining properties.
Additional information:
Affected modules and functionalities:
Frontend Pipeline under deserialization.
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A