New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/glue crawler trailing space failure #202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…railing_space_failure
rajeee
reviewed
Dec 18, 2020
…@rajeee Co-authored-by: Rajendra Adhikari <Rajendra.Adhikari@nrel.gov>
@nmerket it fails because now the code checks the s3 directory for files before attempting to run the glue crawler. Because the CI isn't accessing a real s3 bucket, this fails. I assume the solution is to mock an s3 response, but I couldn't figure out how to do this and that's why the PR was sitting. |
nmerket
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159
Pull Request Description
Removes any trailing slash from s3_prefix to avoid Athena table creation issues. Also warns if the target s3 directory is empty, which would result in an unexpectedly empty table in Athena.
Checklist
Not all may apply