Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simulation flow upgrades #174

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

simulation flow upgrades #174

wants to merge 22 commits into from

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Jan 20, 2022

closes #146

@jd-lara jd-lara added the breaking This doesn't seem right label Jan 20, 2022
@jd-lara jd-lara self-assigned this Jan 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2022 •
edited

Performance Results

Version Precompile Time
Master 14.477439591
This Branch 10.409594196
Version Execute Time
Master- ResidualModel FAILED TO TEST
Master-MassMatrixModel FAILED TO TEST
This Branch-Build ResidualModel 26.938010986
This Branch-Execute ResidualModel 113.079024709
This Branch-MassMatrixModel FAILED TO TEST

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests

@jd-lara jd-lara marked this pull request as draft January 21, 2022 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigomha rodrigomha Awaiting requested review from rodrigomha

At least 1 approving review is required to merge this pull request.

Assignees

@jd-lara jd-lara

Labels
breaking This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-run simulation without reset
1 participant
@jd-lara