Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing HyFeat-2-Coastal grid crosswalk from yaml #766

Merged
merged 5 commits into from
May 29, 2024

Conversation

JurgenZach-NOAA
Copy link
Contributor

Generalization of previous hard-coded SCHISM grid crosswalk to any coastal grid

Additions

  • Import of crosswalk dictionary with coastal grid from yaml file
  • Added (as a non-limiting example) example file for SCHISM study area in domain folders of Lower Colorado examples

Removals

  • Previous hardcoded crosswalk

Changes

-Repurposed obsolete yaml file "coastal_boundary_domain" for the purpose of crosswalk dictionary import

Testing

  1. Functionality in terms of non-interference with unrelated modeling: run Lower test Colorado examples
  2. Further testing requires access to specific coastal modeling output grids, e.g., SCHISM

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 馃憞)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool 鉃★笍

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

Commit now robust with respect to empty coastal-Hy crosswalks, or crosswalks that do not overlap the model actually routed.
@JurgenZach-NOAA JurgenZach-NOAA merged commit 26aea4b into NOAA-OWP:master May 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants