Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify compilation of t-route on WSL #707

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JurgenZach-NOAA
Copy link
Contributor

To simplify compilation of t-route on non-traditional compute environments such as WSL, added the option to set a new alternative NETCDF environment variable, without interfering with the existing compile procedures (if said NETCDFALTERNATIVE is not defined). The value-add here is that no custom conda environment is needed any longer to set the pesky NETCDF include path on WSL.

Additions

  • Adding optional logic for NETCDFALTERNATIVE to compiler.sh

Removals

Changes

Testing

  1. On environments such as WSL, set your own alternative NETCDF include directory, e.g.:
    export NETCDFALTERNATIVE=$HOME/.conda/envs/py39/include/,
    Then run ./compiler.sh as before.

  2. If that is not desired, follow present instructions, there are no changes.

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 馃憞)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool 鉃★笍

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

Copy link
Contributor

@kumdonoaa kumdonoaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is still working for apd-dev. Good to go from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants