Timelog #632
Open
Timelog #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorvath-noaa
requested changes
Aug 16, 2023
Comment on lines
+97
to
+98
| segment_attributes=self._segment_attributes, | ||
| waterbody_attributes=self._waterbody_attributes) |
There was a problem hiding this comment.
It looks like your branch has not been rebased with recent changes to the master branch. These two lines are attempting to undo an edit in PR#622. Can you rebase this branch locally?
| 'data_assimilation_time' : 0, | ||
|
|
||
| } | ||
| # self.main_start_time = time.time() |
There was a problem hiding this comment.
Can you delete this line rather than commenting out?
| self._network._qlateral = pd.DataFrame(index=self._network.segment_index).join( | ||
| pd.DataFrame(values['land_surface_water_source__volume_flow_rate'], | ||
| index=values['land_surface_water_source__id']) | ||
| index=values['segment_id']) |
There was a problem hiding this comment.
This too is attempting to revert changes from PR#622.
Comment on lines
-130
to
-135
| # Trim the time-extent of the streamflow_da usgs_df | ||
| # what happens if there are timeslice files missing on the front-end? | ||
| # if the first column is some timestamp greater than t0, then this will throw | ||
| # an error. Need to think through this more. | ||
| if not self._data_assimilation.usgs_df.empty: | ||
| self._data_assimilation._usgs_df = self._data_assimilation.usgs_df.loc[:,self._network.t0:] |
There was a problem hiding this comment.
Same thing here, reverting changes from PR#622
| # update t0 | ||
| self._network.new_t0(self._time_step, nts) | ||
|
|
||
| # get reservoir DA initial parameters for next loop iteration | ||
| self._data_assimilation.update_after_compute(self._run_results, self._time_step*nts) |
Comment on lines
+337
to
+354
| routelink_attr = { | ||
| #link???? | ||
| "key": "id", | ||
| "downstream": "toid", | ||
| "dx": "length_m", | ||
| "n": "n", # TODO: rename to `manningn` | ||
| "ncc": "nCC", # TODO: rename to `mannningncc` | ||
| "s0": "So", | ||
| "bw": "BtmWdth", # TODO: rename to `bottomwidth` | ||
| #waterbody: "NHDWaterbodyComID", | ||
| "tw": "TopWdth", # TODO: rename to `topwidth` | ||
| "twcc": "TopWdthCC", # TODO: rename to `topwidthcc` | ||
| "alt": "alt", | ||
| "musk": "MusK", | ||
| "musx": "MusX", | ||
| "cs": "ChSlp" # TODO: rename to `sideslope` | ||
| } | ||
| supernetwork_parameters["columns"] = routelink_attr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update time-logging issue #625
Additions
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other