Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error with unknown extensions. #597

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

groutr
Copy link
Contributor

@groutr groutr commented Dec 8, 2022

Raise some sort of error when an unknown file extension is passed to read_file. This will avoid an unbound variable.

Copy link
Contributor

@kumdonoaa kumdonoaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to always have this kind of checkpoint.

@groutr
Copy link
Contributor Author

groutr commented Dec 8, 2022

The building_forcing_sets in this same file function also has several issues. One thing I'm perplexed by is the assumption of a very specifically formatted glob string on L117 (https://github.com/NOAA-OWP/t-route/blob/master/src/troute-network/troute/hyfeature_network_utilities.py#L117).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants