Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nwm_client_new routelink source for NWM v3.0 expanded domain #249

Merged
merged 7 commits into from Mar 20, 2024

Conversation

jarq6c
Copy link
Collaborator

@jarq6c jarq6c commented Mar 20, 2024

National Water Model v3.0 became operational in August 2023 with an expanded domain that includes parts of Alaska. This PR updates the source the nwm_client_new package uses to construct its crosswalk from NWM feature IDs to USGS site codes to include Alaska. It also adds the newly available model configuration labels to the list of valid configurations.

Additions

  • Added new model configurations to list of compatible client configurations. See example added to README.md
  • Libraries dependent on xarray complained about dask-expr. I added this as a dependency to setup.cfg.

Removals

  • None.

Changes

  • Altered a test due to an upcoming change in compatible strings for pandas.Timedelta.

Testing

  1. pytest reported over 15k deprecation errors from pydantic, numpy, and xarray/dask originating from lower level libraries. This was in Python 3.10.
  2. NOMADS has been a bit unstable, causing slow tests to fail due to timeout (which is currently set to 900 seconds).
  3. Python 3.8 is EOL in 2024-10. Probably time to add 3.11 to GH tests.

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • PR is well outlined and documented. See #12 for an example
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (see CONTRIBUTING.md)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output) using numpy docstring formatting
  • Placeholder code is flagged / future todos are captured in comments
  • Reviewers requested with the Reviewers tool ➡️

@jarq6c jarq6c added the enhancement New feature or request label Mar 20, 2024
@jarq6c jarq6c self-assigned this Mar 20, 2024
@jarq6c jarq6c merged commit 6360977 into NOAA-OWP:main Mar 20, 2024
3 checks passed
@jarq6c
Copy link
Collaborator Author

jarq6c commented Mar 20, 2024

@jarq6c jarq6c deleted the update-routelink branch March 20, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

question about update cycle for hydrotools
1 participant