Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update events for pandas v3.0 compatibility #247

Merged
merged 5 commits into from Feb 20, 2024

Conversation

jarq6c
Copy link
Collaborator

@jarq6c jarq6c commented Feb 9, 2024

Short and sweet update.

  1. pandas v3.0 time manipulation methods will only use h (lower case) to indicate hour. This update changes all references to hour from H to h.
  2. Fill methods like (fillna, ffill, bfill) will require you to explicitly indicate that you want them to infer datatypes or must be preceded by an explicit type declaration using astype. I added an astype where needed.

Closes #246

Checklist

  • PR has an informative and human-readable title
  • PR is well outlined and documented. See #12 for an example
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (see CONTRIBUTING.md)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output) using numpy docstring formatting
  • Placeholder code is flagged / future todos are captured in comments
  • Reviewers requested with the Reviewers tool ➡️

@jarq6c jarq6c requested a review from aaraney February 9, 2024 15:43
Copy link
Member

@aaraney aaraney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks, @jarq6c!

@aaraney aaraney merged commit 7fae153 into NOAA-OWP:main Feb 20, 2024
3 checks passed
@jarq6c jarq6c deleted the events-future-fix branch February 28, 2024 15:44
@jarq6c
Copy link
Collaborator Author

jarq6c commented Feb 28, 2024

Thanks @aaraney !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event Detection methods are raising FutureWarning
2 participants