New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing appveyor.yml with Ubuntu #4271
Conversation
70dea25
to
8efb6f3
Compare
8efb6f3
to
9661910
Compare
@304NotModified Well now it is possible to run Ubuntu-build on AppVeyor. It is faster than waiting for Travis, but still a single build takes 25 mins because one also is queued for Ubuntu-build on AppVeyor. It also revealed that NLog is hit by this "bug" on the Linux-platform, that causes NLog Config Variables to no longer work on Net50-platform with Linux. dotnet/runtime#43736 (Will make a PR for the master-branch for this) I think we should move to AppVeyor and drop Travis. Unless you have some secret desire for the more unstable Azure DevOps Pipeline or the untested Github-Actions? |
2101ef8
to
7b0898b
Compare
7b0898b
to
ca78fe8
Compare
I prefer of course stability. Unfortunately the single agent on AppVeyor was for me a reason to try moving to Azure. Unfortunately this was never fully completed because of the stability and a lot of release scripts where build on AppVeyor. 25min is long....I'm doubting if we should not try Azure for Linux, it's has more agents and work in parallel. |
Heavy change in .net 5! We don't need a separate build for .net 5, but only adding the stringComparison for every indexOf and contains? |
Yes think it is going to give a lot of headache all around. Seems it is only |
But since you agree to move away from Travis, then maybe this will be an okay alternative until someone comes around and fixes the Azure Pipeline? For me having a 2 hour integration-build on Travis, makes it a little hard to move forward. Hopefully when NLog 5.0 has been released, then all the "exotic" targets can be moved out of the NLog-core-repository and reduce build-times (and instability because of database-service-issues).
It is actually 16 mins, but there is 10 mins queue time before Ubuntu-build begins. |
Kudos, SonarCloud Quality Gate passed! |
2 hours? Travis takes 8min? Or do you mean with restarts? |
Takes 2 hours to complete a Travis build because of queue time. See also linked issue at the beginning. See also #4273 where it takes 1 hour in weekend from scheduled to run. On normal weekdays when USA is awake then it is double up.
|
Ow thanks, I missed something. Ok drop travis indeed. But I think it's wise if we could try Azure as 10 min queue is also not very nice. I'm not sure if you've the rights to change the Azure pipeline. In my experience the Linux build agents are more stable than the windows ones. |
I think I have spent enough time on getting AppVeyor running, so I will leave it for someone else to play around with Azure Pipelines. But I guess if you remove Travis, then the "conversion" must also happen on master-branch? |
But if you can have 10 parallel jobs on Azure Pipelines then you could do this:
But I think this has to wait until all exotic targets has been removed from NLog. So after NLog 5.0 has been completed, and the exotic targets has moved to own repositories. Right now Azure Pipelines fails 2 out of 3 on Windows, and if having 3 parallel builds that all need to succeed then it will never be a success. |
@304NotModified So are you ready to disable Travis as pull-request requirement, after merging this pull-request? |
Yes Will do that! |
Could consider to update the master-branch to drop Travis aswell, but lets see. Maybe NLog 5.0 will ready before another release from master is needed. |
@304NotModified The PullRequest has now been merged, so you can remove Travis now. |
Done! |
See also #4270