Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function find_best_architecture seems outdated #266

Open
bsolino opened this issue Jul 31, 2020 · 0 comments
Open

Function find_best_architecture seems outdated #266

bsolino opened this issue Jul 31, 2020 · 0 comments

Comments

@bsolino
Copy link
Contributor

bsolino commented Jul 31, 2020

After several changes in other parts of the code, it seems function find_best_architecture in find_architecture.py has fallen behind:

def find_best_architecture(X_train, y_train, X_val, y_val, verbose=True,

This hasn't failed any test yet, but it still generates warnings that are not trivial to solve.

So far what I've noticed is that it doesn't allow to select which network models to test, the function calls to modelgen without specifying them, using only the default.
Something that might be worth adding is a selection of models to test. This will also help the test suite, as sometimes there are warnings regarding the acura

@bsolino bsolino created this issue from a note in Sprint 07/2020 (Todo) Jul 31, 2020
@bsolino bsolino removed this from Todo in Sprint 07/2020 Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant