Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings in tests #264

Open
bsolino opened this issue Jul 31, 2020 · 1 comment
Open

Warnings in tests #264

bsolino opened this issue Jul 31, 2020 · 1 comment

Comments

@bsolino
Copy link
Contributor

bsolino commented Jul 31, 2020

The current tests are giving 6 avoidable/expected warnings:

https://travis-ci.org/github/NLeSC/mcfly/jobs/713626858#L2807

tests/test_find_architecture.py::FindArchitectureBasicSuite::test_find_best_architecture

tests/test_integration.py::IntegrationSuite::test_integration

tests/test_storage.py::StorageSuite::test_loadmodel

tests/test_storage.py::StorageSuite::test_savemodel

tests/test_storage.py::StorageSuite::test_savemodel_keras

  /home/travis/miniconda/envs/test-environment/lib/python3.7/site-packages/mcfly/modelgen.py:88: UserWarning: Specified number_of_models is smaller than the given number of model types.

    warnings.warn("Specified number_of_models is smaller than the given number of model types.")

tests/test_integration.py::IntegrationSuite::test_integration

  /home/travis/miniconda/envs/test-environment/lib/python3.7/site-packages/mcfly/find_architecture.py:240: UserWarning: Argument 'metric' is deprecated and will be ignored.

    warnings.warn("Argument 'metric' is deprecated and will be ignored.")
@bsolino bsolino created this issue from a note in Sprint 07/2020 (Todo) Jul 31, 2020
@bsolino bsolino self-assigned this Jul 31, 2020
@bsolino bsolino moved this from Todo to In progress in Sprint 07/2020 Jul 31, 2020
@bsolino bsolino linked a pull request Jul 31, 2020 that will close this issue
@bsolino bsolino moved this from In progress to Ready for review in Sprint 07/2020 Jul 31, 2020
@bsolino
Copy link
Contributor Author

bsolino commented Jul 31, 2020

Pull request #265 solved trivial warnings, one non trivial warning is missing: https://travis-ci.org/github/NLeSC/mcfly/jobs/713646901#L2807
It is related to issue #266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Sprint 07/2020
Ready for review
Development

Successfully merging a pull request may close this issue.

1 participant