Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:table): no data virtual height #8457

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ParsaArvanehPA
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Not possible to pass the no data virtual height.
Typo fixed: noDateVirtualHeight => noDataVirtualHeight

Issue Number: #8446

What is the new behavior?

Described in the issue #8446

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

Copy link

zorro-bot bot commented Mar 20, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.61%. Comparing base (2576612) to head (d9f2364).
Report is 45 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #8457    +/-   ##
========================================
  Coverage   91.60%   91.61%            
========================================
  Files         519      530    +11     
  Lines       18074    18392   +318     
  Branches     2848     2813    -35     
========================================
+ Hits        16557    16850   +293     
- Misses       1218     1225     +7     
- Partials      299      317    +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants