Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:table): radio selection type #8456

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

ParsaArvanehPA
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

In Ant design it is possible to have both checkbox and radio as selection type for columns; meanwhile we only support checkbox selection type.

Issue Number: #8029

What is the new behavior?

Now supports radio selection type.

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

Copy link

zorro-bot bot commented Mar 20, 2024

This preview will be available after the AzureCI is passed.

@ParsaArvanehPA ParsaArvanehPA changed the title Feature/radio selection in tables feat(module:table): radio selection type Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 91.59%. Comparing base (2576612) to head (5e4dd2a).
Report is 45 commits behind head on master.

Files Patch % Lines
components/table/src/cell/td-addon.component.ts 60.00% 1 Missing and 1 partial ⚠️
components/table/src/addon/selection.component.ts 0.00% 1 Missing ⚠️
...omponents/table/src/cell/th-selection.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8456      +/-   ##
==========================================
- Coverage   91.60%   91.59%   -0.02%     
==========================================
  Files         519      530      +11     
  Lines       18074    18397     +323     
  Branches     2848     2814      -34     
==========================================
+ Hits        16557    16850     +293     
- Misses       1218     1229      +11     
- Partials      299      318      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants