Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:rate): remove deprecated observers #8454

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nicoss54
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Currently we used observers.length to check if something subscribe to a subject. Unfortunatly this is deprecated in will be remove in the next version of rxjs (v8).

Observers will become internal.

Issue Number: N/A

What is the new behavior?

Use the new isObserved getter to check if something subscribe to a Subject

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Copy link

zorro-bot bot commented Mar 20, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.60%. Comparing base (116346f) to head (179b4f8).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8454      +/-   ##
==========================================
- Coverage   91.62%   91.60%   -0.02%     
==========================================
  Files         530      530              
  Lines       18390    18390              
  Branches     2815     2815              
==========================================
- Hits        16849    16847       -2     
- Misses       1225     1226       +1     
- Partials      316      317       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HyperLife1119
Copy link
Collaborator

HyperLife1119 commented Mar 21, 2024

This 'observed' property does not yet exist in rxjs6. Since angular/core still supports rxjs6, we can't do this yet.

@Nicoss54
Copy link
Collaborator Author

This 'observed' property does not yet exist in rxjs6. Since angular/core still supports rxjs6, we can't do this yet.

lets keep it in draft mode and blocked if you are agree ?

@Nicoss54 Nicoss54 marked this pull request as draft March 21, 2024 09:02
@HyperLife1119
Copy link
Collaborator

Totally agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants