Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:spin): now supports fullscreen #8183

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ParsaArvanehPA
Copy link
Contributor

@ParsaArvanehPA ParsaArvanehPA commented Nov 24, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The spin component in our current version does not have the fullscreen mode feature that antd provides.

Issue Number: N/A

What is the new behavior?

The spin component has a new input property called nzFullscreen, which enables the display of a backdrop with the spin component when set to true.

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.72%. Comparing base (43b34ae) to head (66afc3c).
Report is 178 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8183      +/-   ##
==========================================
+ Coverage   91.70%   91.72%   +0.01%     
==========================================
  Files         519      519              
  Lines       17885    17888       +3     
  Branches     2747     2836      +89     
==========================================
+ Hits        16401    16407       +6     
+ Misses       1182     1180       -2     
+ Partials      302      301       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

z-index: 1000;
max-height: unset;

.ant-spin-dot-item {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.@{spin-prefix-cls}-item

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to .@{spin-prefix-cls}-dot-item

@HyperLife1119
Copy link
Collaborator

HyperLife1119 commented Nov 25, 2023

This feature involves several design tokens, and we may need more work to support it. These design tokens may also affect our style synchronization work.
https://github.com/ant-design/ant-design/blob/03409af97f8fa8b32acad7a388eb3fd8640c7c35/components/spin/style/index.ts#L67-L92

WDYT? @simplejason @OriginRing

@ParsaArvanehPA
Copy link
Contributor Author

This feature involves several design tokens, and we may need more work to support it. These design tokens may also affect our style synchronization work. https://github.com/ant-design/ant-design/blob/03409af97f8fa8b32acad7a388eb3fd8640c7c35/components/spin/style/index.ts#L67-L92

WDYT? @simplejason @OriginRing

I am not clear about what you mean by design tokens. Do you mean the style changes that make the spin component white? How does this affect the feature and the style synchronization work? Can we use the current design tokens until we support the new ones?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants