Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility by adding more aria support #5658

Closed

Conversation

PontusKberg
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4707

What is the new behavior?

Added additional aria roles, labels and states to a select number of components

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

These changes are intended to increase the accessibility of some NG-ZORRO components. There are still many more components whose accessibility can be improved, but which are not addressed by this PR.

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #5658 into master will decrease coverage by 0.00%.
The diff coverage is 84.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5658      +/-   ##
==========================================
- Coverage   90.31%   90.30%   -0.01%     
==========================================
  Files         455      455              
  Lines       13788    13828      +40     
  Branches     2258     2189      -69     
==========================================
+ Hits        12452    12488      +36     
+ Misses        819      814       -5     
- Partials      517      526       +9     
Impacted Files Coverage Δ
components/menu/menu-item.directive.ts 75.80% <ø> (ø)
components/menu/submenu-inline-child.component.ts 91.66% <57.14%> (-8.34%) ⬇️
...ponents/menu/submenu-non-inline-child.component.ts 79.41% <62.50%> (-5.78%) ⬇️
components/dropdown/dropdown.directive.ts 88.88% <80.00%> (-0.48%) ⬇️
components/dropdown/dropdown-menu.component.ts 90.47% <100.00%> (+0.47%) ⬆️
components/icon/icon.directive.ts 95.45% <100.00%> (+0.29%) ⬆️
components/input-number/input-number.component.ts 97.48% <100.00%> (+0.02%) ⬆️
components/menu/menu.directive.ts 90.16% <100.00%> (+0.33%) ⬆️
components/menu/menu.service.ts 91.30% <100.00%> (+3.06%) ⬆️
components/menu/submenu.component.ts 98.92% <100.00%> (+0.04%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5899ad...fad8887. Read the comment docs.

@mixalistzikas
Copy link

Any progress on this ticket?

@wzhudev
Copy link
Member

wzhudev commented Feb 10, 2022

@PontusKberg Hi! Thanks for openning this PR. It seems that there are some merging conflicts. Could you please resolve them?

@PontusKberg PontusKberg closed this by deleting the head repository Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants