-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/simulator implementation ky #1
Open
NhiNguyencmt8
wants to merge
35
commits into
main
Choose a base branch
from
feature/simulator_implementation_ky
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Updated CMakeLists.txt files. 3. Initial implementation of real robot files (UNTESTED).
2. Added Apptainer definition files to allow building/testing with containers.
2. Added Ackermann steering control interface and real robot code. 3. Cleaned up code. 4. Fixed bugs related to Lua dependency (code doesn't actually need Lua).
…bot_implementation_ky
Since Ackermann steering doesn't yet exist in ARGoS3, generic classes are added for the time being under the argos3-deepracer repo. Once this is fully tested and works, a PR should be submitted to the `argos3` repo for integration. At this point, the integration should work out as follows: - `plugins/robots/deepracer/control_interface/ci_ackermann_steering_actuator.*` -> `plugins/robots/generic/control_interface/ci_ackermann_steering_actuator.*` - `plugins/robots/deepracer/simulator/ackermann_steering_default_actuator.*` -> `plugins/robots/generic/simulator/ackermann_steering_default_actuator.*` - `plugins/robots/deepracer/simulator/dynamics2d_ackermannsteering_control.*` -> `plugins/simulator/physics_engines/dynamics2d/dynamics2d_ackermannsteering_control.*` - `plugins/robots/deepracer/simulator/deepracer_imu_sensor_equipped_entity.*` -> `plugins/simulator/entities/imu_sensor_equipped_entity.*` - `plugins/robots/deepracer/simulator/ackermann_wheeled_entity.*` -> `plugins/simulator/entities/ackermann_wheeled_entity.*`
Implementation is incomplete and untested. Currently only a bare-bones implementation to have structures/placeholders in place; not even ready for building.
…lator_implementation_ky
1. Updated the CI to use regular steering angle and throttle speed. 2. Fixed typo to avoid confusion in indicating vehicle speed from throttle (instead of 'throttled_speed' which could mean 'reduced speed', changed to 'throttle_speed'). 3. Updated Ackermann wheeled entity implementation to allow setting of steering and throttle.
The IMU sensor is inspired heavily by the [positioning sensor](https://github.com/ilpincy/argos3/blob/master/src/plugins/robots/generic/simulator/positioning_default_sensor.cpp). Accordingly the CI of the IMU sensor has also been updated. The `real_deepracer_imu_sensor` class hasn't been updated yet.
Build was successful, but code has not been tested on robot. Also fixed some variable names.
…bot_implementation_ky
…lator_implementation_ky
1. Modified shared ownership of node object (now a shared pointer) by the device classes. 2. Updated real robot version of the LIDAR sensor to allow sending of start and stop service requests. 3. Updated wheel placement positions. 4. Updated Apptainer image definition file for compiling ARGoS on a real robot.
1. Included .obj and .blend files. 2. Added new measurements and fixed LiDAR fan angle. 3. Updated dynamic model; collision shape is untested still. 4. Minor bugfixes.
…ementation_with_camera
…ulator_implementation_ky
1. Collision, IMU sensor untested yet, but LIDAR seems fine. 2. Diffusion controller doesn't actually diffuse; only moves the robot. 3. .argos experiment file executes, but only contains a single robot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simulation Lidar and IMU done. I'll update the README on the main repo