Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of start date in advanced search #1103

Merged
merged 1 commit into from Nov 12, 2018
Merged

Conversation

maradragan
Copy link
Contributor

The date widget in the advanced search was displaying a day earlier than
the day it should have. Here is why:
moment/moment#3086

Closes #1099

@maradragan maradragan added the bug label Nov 9, 2018
@maradragan maradragan added this to To do in Bugs via automation Nov 9, 2018
@codecov
Copy link

codecov bot commented Nov 9, 2018

Codecov Report

Merging #1103 into candidate will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             candidate    #1103   +/-   ##
============================================
  Coverage        56.58%   56.58%           
  Complexity        1284     1284           
============================================
  Files              141      141           
  Lines             6166     6166           
  Branches           743      743           
============================================
  Hits              3489     3489           
  Misses            2297     2297           
  Partials           380      380

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53b8976...d7ca8f9. Read the comment docs.

@maradragan maradragan moved this from To do to Ready for review in Bugs Nov 9, 2018
@maradragan maradragan self-assigned this Nov 9, 2018
@maradragan maradragan removed this from Ready for review in Bugs Nov 9, 2018
@maradragan maradragan removed their assignment Nov 9, 2018
Copy link
Collaborator

@gjvoosten gjvoosten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a global const for the 'YYYY-MM-DD' format?

The date widget in the advanced search was displaying a day earlier than
the day it should have. Here is why:
moment/moment#3086
@VassilIordanov VassilIordanov merged commit 6a1a432 into candidate Nov 12, 2018
@VassilIordanov VassilIordanov deleted the GH-1099 branch November 12, 2018 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants